[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added a comment. > [Damangle] Damangle? dAmangle? *sigh* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(); +Demangler D(MangledName.data()); +const char *M = D.parseMangle();

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(); +Demangler D(MangledName.data()); +const char *M = D.parseMangle(); efriedma

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

efriedma added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(); +Demangler D(MangledName.data()); +const char *M = D.parseMangle(); Isn't this still

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5371eb3d3ae: [Damangle] convert dlangDemangle to use std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 528011. nickdesaulniers added a comment. This revision is now accepted and ready to land. - rebase on D149675 , remove nullptr check No, I don't want no nullptr-check A nullptr-check is a guard that can't get no love

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string ) { + if (!MangledName) +return false; MaskRay wrote: > nickdesaulniers wrote: > > nickdesaulniers

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. If `nonMicrosoftDemangle` is going to be changed to take a `string_view` argument, adding `if (!MangledName) return false;` should be fine. If possible, it's best for the change to be

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

MaskRay added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string ) { + if (!MangledName) +return false; nickdesaulniers wrote: > nickdesaulniers wrote: > > MaskRay wrote: > >

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527900. nickdesaulniers added a comment. - rebase for presubmits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 Files: lldb/source/Core/Mangled.cpp

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string ) { + if (!MangledName) +return false;

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string ) { + if (!MangledName) +return false; MaskRay

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

MaskRay added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string ) { + if (!MangledName) +return false; Why is this change? The original contract is that `MangledName` must be

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527514. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 Files: lldb/source/Core/Mangled.cpp

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. needs rebasing for presubmit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. I was doing this API conversion to use