Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-08 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255014: Add a new option to Platform::LoadImage to install the image (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D15152?vs=42055&id=42166#toc Repository: rL LLVM http

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-07 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: include/lldb/API/SBProcess.h:301-307 @@ +300,9 @@ + +// Load an image to the currently running process. +// If both local and remote image is specified then copy the local image to the remote image and +// then load it fr

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-07 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 42055. tberghammer added a comment. Update API documentation in SBProcess.h http://reviews.llvm.org/D15152 Files: include/lldb/API/SBProcess.h include/lldb/Target/Platform.h packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-04 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Add header doc for the new LoadImage and make Platform::LoadImage virtual in case platforms want to override this and this is good to go. Comment at: include/ll

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-04 Thread Tamas Berghammer via lldb-commits
tberghammer retitled this revision from "Change Platform::LoadImage to copy the file to the remote platform" to "Add a new option to Platform::LoadImage to install the image". tberghammer updated the summary for this revision. tberghammer updated this revision to Diff 41877. tberghammer added a c