This revision was automatically updated to reflect the committed changes.
Closed by commit rG8e0001eb95ce: [lldb][NFCI] Refactor
Language::GetFormatterPrefixSuffix (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151603/new/
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151603/new/
https://reviews.llvm.org/D151603
___
lldb-commits mailing list
bulbazord updated this revision to Diff 526705.
bulbazord added a comment.
Remove use of `std::call_once` where not needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151603/new/
https://reviews.llvm.org/D151603
Files:
bulbazord added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:1001
-bool ObjCLanguage::GetFormatterPrefixSuffix(ValueObject ,
-ConstString type_hint,
-
Michael137 added a comment.
modulo Felipe's comment, LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151603/new/
https://reviews.llvm.org/D151603
___
lldb-commits mailing list
fdeazeve added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:1001
-bool ObjCLanguage::GetFormatterPrefixSuffix(ValueObject ,
-ConstString type_hint,
-
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl, Michael137,
kastiglione.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
- Remove unused parameter
