Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-04 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL254710 Repository: rL LLVM http://reviews.llvm.org/D15182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-04 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. Thanks. If you wish, you can link it to the same bug as the arm xfail above, as that is the same underlying issue. Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-03 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 41840. jaydeep added a comment. Marked as XFAIL Repository: rL LLVM http://reviews.llvm.org/D15182 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py Index: packages/Python/lldbsuite/test/functional

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-03 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. I believe this defeats the purpose of the whole test, which (I think) is to check that crashes during the actual "step" operation are handled correctly. We already have other tests which test crashing after a "continue" so I don't think

[Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-03 Thread Jaydeep Patil via lldb-commits
jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: bhushan, sagar, mohit.bhakkad, nitesh.jain, lldb-commits. jaydeep set the repository for this revision to rL LLVM. Single stepping requires setting software breakpoint at address 0x0. This results in in