This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe8966125e281: [lldb/Commands] Fix disk completion from root
directory (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
Ok, this looks fine to me. I'm not 100% sure this will work on Windows, but we
neither Ismail nor I have windows machines to test this on. Watch the windows
bots please.
CHANGES SINCE
mib updated this revision to Diff 528560.
mib marked an inline comment as done.
mib added a comment.
Address @bulbazord comments!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152013/new/
https://reviews.llvm.org/D152013
Files:
lldb/source/Commands/CommandCompletions.cpp
mib marked an inline comment as done.
mib added inline comments.
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:439-450
+def test_completion_target_create_from_root_dir(self):
+"""Tests source file completion by completing ."""
+
bulbazord added inline comments.
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:439-450
+def test_completion_target_create_from_root_dir(self):
+"""Tests source file completion by completing ."""
+root_dir = os.path.abspath(os.sep)
+
mib updated this revision to Diff 528058.
mib added a comment.
Add test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152013/new/
https://reviews.llvm.org/D152013
Files:
lldb/source/Commands/CommandCompletions.cpp
lldb/test/API/functionalities/completion/TestCompletion.py
Index:
bulbazord added a comment.
The change itself looks ok to me. Could you add a test for this? We do have
some tests to test for completion so the machinery is there, but it's mostly
for the expression evaluator right now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mib created this revision.
mib added reviewers: JDevlieghere, bulbazord, kastiglione.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch should fix path completion starting from the root directory.
To
