[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

2023-06-14 Thread Kazuki Sakamoto via Phabricator via lldb-commits
splhack abandoned this revision. splhack added a comment. @bulbazord thanks for the suggestion! property works well. D152933 supersedes this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152494/new/ https://revi

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

2023-06-13 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. An environment variable isn't the worst thing in the world, but what would be better is an lldb setting so we can change it at runtime instead of needing to restart the debugging session. That may happen if you make a typo or make a mistake. Something like `plugin.pla

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

2023-06-12 Thread Nathan Lanza via Phabricator via lldb-commits
lanza accepted this revision. lanza added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152494/new/ https://reviews.llvm.org/D152494

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

2023-06-08 Thread Kazuki Sakamoto via Phabricator via lldb-commits
splhack created this revision. splhack added a reviewer: clayborg. Herald added a subscriber: danielkiss. Herald added a project: All. splhack edited the summary of this revision. splhack added reviewers: labath, lanza. splhack published this revision for review. Herald added a project: LLDB. Heral