[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

2023-06-21 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbcfe5a52a39d: [lldb] Add register field tables to the register info command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

2023-06-14 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Putting this in `register info` is good, it's not too easily discoverable (to be honest I didn't know this command existed today), but as you say, the number of people who

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

2023-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. This is the major use case for the command. With these diagrams matching the architecture manual (mostly) you can use them to work out what mask/shift you need. You'll be able to print a register, see that the field isn't the right value, then "register info" and

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

2023-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This teaches DumpRegisterInfo to generate a table from the register flags type. It just calls a method on