This revision was automatically updated to reflect the committed changes.
Closed by commit rG5f45a87bf029: [lldb] Print hint if object description is
requested but not implemented (authored by augusto2112).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
augusto2112 updated this revision to Diff 546275.
augusto2112 added a comment.
Addressed comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153489/new/
https://reviews.llvm.org/D153489
Files:
lldb/include/lldb/Core/Debugger.h
augusto2112 marked an inline comment as done.
augusto2112 added inline comments.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135
+ << "note: object description requested, but type doesn't implement "
+ "a custom object description.
kastiglione added inline comments.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135
+ << "note: object description requested, but type doesn't implement "
+ "a custom object description. Consider using \"p\" instead of "
+
augusto2112 added inline comments.
Comment at: lldb/include/lldb/Target/Target.h:496
+ std::once_flag target_once_flag;
// These two functions fill out the Broadcaster interface:
kastiglione wrote:
> did you mean to use this, or should it be deleted?
kastiglione added inline comments.
Comment at: lldb/include/lldb/Target/Target.h:496
+ std::once_flag target_once_flag;
// These two functions fill out the Broadcaster interface:
did you mean to use this, or should it be deleted?
Comment
augusto2112 added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153489/new/
https://reviews.llvm.org/D153489
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
augusto2112 updated this revision to Diff 535561.
augusto2112 marked 5 inline comments as done.
augusto2112 added a comment.
Addressed comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153489/new/
https://reviews.llvm.org/D153489
Files:
kastiglione added inline comments.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.h:46-51
+ /// Add a hint if object description was requested, but no description
+ /// function was implemented, and dump valobj to output_stream after.
+ static void
kastiglione added a comment.
> I wonder if we should hint in all 3 command objects (expr, frame var and
> DWIM) or if we should limit this to DWIM instead (since DWIM is the one
> aliased to p and po and I don't think vo or expr -O are often used
> unintentionally).
I missed this comment. My
kastiglione added inline comments.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:81-83
+<< "note: object description requested, but type doesn't implement "
+ "a custom object description. Consider using \"p\" instead of "
+ "\"po\"\n";
augusto2112 added a comment.
ping :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153489/new/
https://reviews.llvm.org/D153489
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
augusto2112 added a comment.
Herald added subscribers: Michael137, JDevlieghere.
@kastiglione I wonder if we should hint in all 3 command objects (expr, frame
var and DWIM) or if we should limit this to DWIM instead (since DWIM is the
one aliased to p and po and I don't think `vo` or `expr -O`
augusto2112 created this revision.
augusto2112 added reviewers: kastiglione, jingham.
Herald added a project: All.
augusto2112 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Lots of users use "po" as their default print command. If the
14 matches
Mail list logo
