splhack updated this revision to Diff 539238.
splhack added a comment.
- Rename 'get module callback' to 'locate module callback'
- SBPlatform will do
- capture callback(SBPlatformLocateModuleCallback) and baton(void *)
- convert ModuleSpec/FileSpec from/to SBModuleSpec/SBFileSpec for calling
mib added a comment.
LGTM with @clayborg comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153735/new/
https://reviews.llvm.org/D153735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
splhack added inline comments.
Comment at: lldb/include/lldb/API/SBDefines.h:129
+typedef SBError (*SBTargetGetModuleCallback)(SBDebugger debugger,
+ SBModuleSpec &module_spec,
clayborg wrote:
> If we are putting this
clayborg added inline comments.
Comment at: lldb/include/lldb/API/SBDefines.h:129
+typedef SBError (*SBTargetGetModuleCallback)(SBDebugger debugger,
+ SBModuleSpec &module_spec,
If we are putting this into SBPlatform,
splhack updated this revision to Diff 538835.
splhack added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153735/new/
https://reviews.llvm.org/D153735
Files:
lldb/bindings/python/python-typemaps.swig
lldb/bindings/python/pyth
splhack updated this revision to Diff 538713.
splhack added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153735/new/
https://reviews.llvm.org/D153735
Files:
lldb/bindings/python/python-typemaps.swig
lldb/bindings/python/pyth
splhack updated this revision to Diff 534804.
splhack added a comment.
Move SetTargetGetModuleCallback from SBDebugger to SBPlatform.
https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580/4?u=splhack
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
splhack created this revision.
Herald added a project: All.
splhack requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580
Use SWIG for the target get module callbac
