Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

2015-12-10 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thanks! Repository: rL LLVM http://reviews.llvm.org/D15374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

2015-12-10 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255308: Add NetBSD support in the buildDriver and buildLibrary routines (authored by kamil). Changed prior to commit: http://reviews.llvm.org/D15374?vs=42372&id=42467#toc Repository: rL LLVM http://

Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

2015-12-09 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 42372. krytarowski added a comment. Strip zero character from platform name Repository: rL LLVM http://reviews.llvm.org/D15374 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

2015-12-09 Thread Ed Maste via lldb-commits
emaste requested changes to this revision. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/test/lldbtest.py:2100 @@ -2099,3 +2099,3 @@ } -elif sys.platform.startswith('freebsd') or sys.platform.startswith("linux") or o

Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

2015-12-09 Thread Joerg Sonnenberger via lldb-commits
joerg added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:2100 @@ -2099,3 +2099,3 @@ } -elif sys.platform.startswith('freebsd') or sys.platform.startswith("linux") or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile': +eli

[Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

2015-12-09 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: emaste, joerg, clay.chang, tfiala. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Herald added a subscriber: emaste. NetBSD is like FreeBSD and Linux in these routines. Repo