[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee476996bec7: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate. (authored by cmtice). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

cmtice added a comment. Herald added subscribers: Michael137, JDevlieghere. I updated the version that I committed to use 'sizeof' as recommended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153840/new/ https://reviews.llvm.org/D153840 _

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

dblaikie added a comment. I'm not sure if this is the right fix - these reads are for implementing DW_OP_deref_size, by the looks of it - so I think it does make sense that the size read is not the size of the address, but the size specified in the DW_OP_deref_size. There is a requirement that

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

jasonmolenda added a comment. I have to agree with David, I don't see how the old code could overflow if DW_OP_deref_size's maximum size is the pointer size in the target, and we are reading it in to an 8-byte buffer, unless the target had addresses larger than 8 bytes, or the dwarf was malform

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

cmtice marked an inline comment as done. cmtice added a comment. Hi Jason, I had been talking more with David, and yes, I had come to the conclusion that you are both right and that this was not the right fix. I am planning on reverting this, but I am trying to figure out the right fix to repl

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

dblaikie added a comment. In D153840#4474213 , @cmtice wrote: > Hi Jason, > > I had been talking more with David, and yes, I had come to the conclusion > that you are both right and that this was not the right fix. I am planning > on reverting this, bu