This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe12c701ff040: [lldb] Use LLVMs implementation of
AppleTables for apple_debug_types (authored by fdeazeve).
Repository:
rG LLVM Github Monorepo
fdeazeve updated this revision to Diff 535162.
fdeazeve added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153867/new/
https://reviews.llvm.org/D153867
Files:
lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
fdeazeve added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232
+
+ llvm::StringRef expected_name = context[0].name;
+
JDevlieghere wrote:
> JDevlieghere wrote:
> > I assume we always have at least one entry (or that's
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232
+
+ llvm::StringRef expected_name = context[0].name;
+
JDevlieghere wrote:
> I assume we always have at least one entry (or that's the assumption here).
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232
+
+ llvm::StringRef expected_name = context[0].name;
+
I assume
fdeazeve created this revision.
Herald added a subscriber: arphaman.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.
This commit is replacing really old LLDB code, and we've found
