[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

2023-07-06 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8929904d88: [lldb] Fix crash when completing register names after program exit (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D154413?vs=537021=537622#toc Repository:

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

2023-07-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154413/new/ https://reviews.llvm.org/D154413

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

2023-07-04 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 537021. DavidSpickett added a comment. Added register info to the x86 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154413/new/ https://reviews.llvm.org/D154413 Files:

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

2023-07-04 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added reviewers: labath, JDevlieghere. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:782 self.complete_from_to("register write rbx ", []) def

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

2023-07-04 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously the following would crash: (lldb) run Process