fdeazeve added a comment.
> There are some potential improvements we could make to this code
Yup, there's a lot I want to change here, but I am taking it slowly in the
interest of making each change easier to verify
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc04b18ad7e4: [lldb][NFC] Factor out code from
SymbolFileDWARF::ParseVariableDIE (authored by fdeazeve).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154513
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
Makes sense to me. There are some potential improvements we could make to this
code (which I'm sure you can already identify), but to keep this change
relatively risk-free we should prob
fdeazeve added inline comments.
Herald added a subscriber: JDevlieghere.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3272
+/// Creates a DWARFExpressionList from an DW_AT_location form_value.
+static DWARFExpressionList GetExprListFromAtLocation(DWARFFo
fdeazeve created this revision.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This function does a _lot_ of different things:
1. Parses a DIE,
2. Builds an ExpressionList
3. Figures out lifetime of v
