This revision was automatically updated to reflect the committed changes.
Closed by commit rG1f5f4169c427: [lldb] Fix dead lock issue when loading
modules in Scripted Process (authored by mib).
Changed prior to commit:
https://reviews.llvm.org/D154649?vs=537846=537887#toc
Repository:
rG
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM. Might be worth adding a little comment there to make sure we remember why
the check is there in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154649/new/
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Yes, that makes sense. lldb always updates its shared library state in
reaction to a stop, so it's much safer to have the scripted process emulate
this behavior. Plus, refreshing the
mib created this revision.
mib added reviewers: jingham, JDevlieghere.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch attempts to fix a dead lock when loading modules in a Scripted
Process.
This