[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe88462cd6aa: Platform qemu-user: Build path to qemu automatically if not specified (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155117/n

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted added a comment. In D155117#4521393 , @labath wrote: > In D155117#4510512 , @ted wrote: > >> In D155117#4505538 , @labath wrote: >> >>> I am wondering if we actually n

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D155117#4510512 , @ted wrote: > In D155117#4505538 , @labath wrote: > >> I am wondering if we actually nee

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted added a comment. As for the GetSupportedArchitectures case, downstream I left in the code that checks the property, but changed the return {}; to return {ArchSpec(llvm::Triple("riscv32-unknown-linux")), ArchSpec(llvm::Triple("riscv64-unknown-linux"))}; I don't think we want that

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted added a comment. In D155117#4505538 , @labath wrote: > I am wondering if we actually need the second step (the architecture setting) > here. The main reason it exists is the usage in `GetSupportedArchitectures` > (which is called before a target is

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

labath added a comment. I am wondering if we actually need the second step (the architecture setting) here. The main reason it exists is the usage in `GetSupportedArchitectures` (which is called before a target is created) it seems like the value derived from the target should always be more co

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted created this revision. Herald added a project: All. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Get the path to qemu in the following order: 1. From the property platform.plugin.qemu-user.emulator-path 2. If that property is no