fdeazeve created this revision.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This rewrites DW_OP_addrx inside DWARFExpression as an DW_OP_addr so that we can
update addresses that are originally loca
fdeazeve updated this revision to Diff 540001.
fdeazeve added a comment.
Minor comment improvements
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155198/new/
https://reviews.llvm.org/D155198
Files:
lldb/source/Expression/DWARFExpression.cpp
ll
fdeazeve updated this revision to Diff 541986.
fdeazeve added a comment.
Rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155198/new/
https://reviews.llvm.org/D155198
Files:
lldb/source/Expression/DWARFExpression.cpp
lldb/unittests/Expres
fdeazeve added a comment.
Hi @clayborg, just wanted to make sure this doesn't fall off your radar :)
This fixes all outstanding DWARF 5 issues with Debug Maps, so it would be cool
if we could get this in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
aprantl added a comment.
As far as I'm concerned, this doesn't look too controversial to me and it is
unblocking one of the bots. I think it would be okay to tentatively land this,
but be on the lookout and promptly react to any post-commit feedback from
@clayborg.
Repository:
rG LLVM Githu
JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
LGTM. I agree with Adrian: we can go ahead and land this to unblock the bots.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155198/new/
https://reviews.llvm.org/D15
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf09f0a6b1076: [lldb] Consider OP_addrx in
DWARFExpression::Update_DW_OP_addr (authored by fdeazeve, committed by aprantl).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
clayborg added a comment.
Sorry for the late response, but I had verbally agreed to this approach when
Felipe and I spoke about how to fix this. LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155198/new/
https://reviews.llvm.org/D155198
