This revision was automatically updated to reflect the committed changes.
Closed by commit rL259644: Add ability to override JIT expr compiler options.
(authored by aidandodds).
Changed prior to commit:
http://reviews.llvm.org/D15527?vs=45588&id=46769#toc
Repository:
rL LLVM
http://reviews.
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Yeah, this looks much cleaner. I'm fine with this.
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
ldrumm added a comment.
I'd like a final review on this patch if one of the code owners can take the
time, please?
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
ldrumm added a comment.
Hi Sean
If you have the time I'd appreciate it if you could take another look over my
latest iteration of this feature.
Thanks
Luke
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ldrumm updated this revision to Diff 45588.
ldrumm added a comment.
Address @spyffe's previous suggestions regarding modifying target options in
place. This allows for a simpler and more maintainable solution than previously
implemented, and requires no extra datatype definitions.
- removed unn
spyffe added a comment.
What I'm getting at here is: OverrideExprOptions just subclasses
clang::TargetOptions if I'm not mistaken. What I might suggest is
virtual bool
OverrideExprOptions (clang::TargetOptions &options)
{
return false; // return true if you actually modified "options"
}
Yo
ldrumm updated this revision to Diff 44794.
ldrumm added a comment.
Responding to Sean Callanan's suggestions in previous differential RE accepting
an existing set of TargetOptions as the basis to configure a custom set.
http://reviews.llvm.org/D15527
Files:
include/lldb/Target/LanguageRunti
ldrumm added a comment.
In http://reviews.llvm.org/D15527#324919, @spyffe wrote:
> I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears
> to generate a new set of options from whole cloth rather than using the
> existing set as a starting point.
>
> Specifically, since
spyffe added a comment.
I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears
to generate a new set of options from whole cloth rather than using the
existing set as a starting point.
Specifically, since your use case is wanting to override the calling
convention, I thi
ldrumm requested a review of this revision.
ldrumm added a comment.
bump
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:85-97
@@ -83,1 +84,15 @@
+namespace {
+void debugStringVector(Log *log, const std::vector& vec,
const char *name)
+{
+
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Sean should OK this as well.
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
ldrumm updated this revision to Diff 43617.
ldrumm marked 2 inline comments as done.
http://reviews.llvm.org/D15527
Files:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
ldrumm removed rL LLVM as the repository for this revision.
ldrumm updated this revision to Diff 43616.
ldrumm added a comment.
Updated implementation as per comment on manually set user language:
http://reviews.llvm.org/D15527#inline-127860 . This patch adds checking for non
eLanguageTypeUnknow
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:85-97
@@ -83,1 +84,15 @@
+namespace {
+void debugStringV
ldrumm added a comment.
FYI This feature was originally discussed on the ML:
http://lists.llvm.org/pipermail/lldb-dev/2015-December/009006.html
Repository:
rL LLVM
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.l
ldrumm created this revision.
ldrumm added reviewers: clayborg, spyffe.
ldrumm added a subscriber: lldb-commits.
ldrumm set the repository for this revision to rL LLVM.
Runtimes should be able to pass custom compilation options to the JIT for their
stack frame. This patch adds a custom expression
16 matches
Mail list logo
