dawn marked 4 inline comments as done.
dawn added a comment.
Replies to Ilia's comments...
Comment at: source/Commands/CommandObjectTarget.cpp:1543
@@ +1542,3 @@
+continue;
+CompileUnit *cu = cu_sp.get();
+const FileSpecList &c
dawn added a comment.
In http://reviews.llvm.org/D15593#313342, @clayborg wrote:
> Dawn, if you don't understand what I asked you to do,
Sorry for late reply - been recovering from minor surgery. I have a new patch,
but I've not yet gone through all of Ilia's additional comments - will probab
clayborg added a comment.
Note that you won't need any of the options that you had added to the other
command becuase the "source info" command will do what you wanted in the first
place: find all line entries where a file and optional line is mentioned in any
line tables.
Repository:
rL LL
clayborg added a comment.
Dawn, if you don't understand what I asked you to do, let me know and I can go
and do the "source info" command for you, then you can modify this patch to
just use the command I added. But it should be simple to just revert and
changes to the original line table dumpin
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:226
@@ -225,3 @@
-// Skip entries which don't match the desired source.
-if (strWantFile != strFile)
-continue;
Is strWantFile needed? Seems it's an
ki.stfu added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:1536-1537
@@ -1508,1 +1535,4 @@
+bool has_path = (file_spec.GetDirectory().AsCString() != 0);
+int ncus = module->GetNumCompileUnits();
+for (size_t i = 0; i < nc
clayborg added a comment.
I do want to apologize to Dawn and Jim for not having chimed in earlier and
causing Dawn some extra work.
Repository:
rL LLVM
http://reviews.llvm.org/D15593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
clayborg added a comment.
Ok, so I talked with Jim on this and this is what we came up with. I would like
to see no changes made to the "target modules dump line-table" command. It is
dumping complete line tables. This command is not for "find any line entries
that match this file anywhere incl
> On Dec 17, 2015, at 10:25 AM, Dawn Perchik wrote:
>
> dawn marked 6 inline comments as done.
> dawn added a comment.
>
>> clang-format your changes please (there are many deviations from the coding
>> style)
>
>
> I've made some fixes even though the code is no longer consistent with the
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Man those options are complex. I really would like to see something more simple:
"--raw" dumps the line entries as you have mentioned
"--no-inlines" would omit any inline entries
dawn updated this revision to Diff 43152.
dawn marked an inline comment as done.
dawn added a comment.
Updated patch with suggestions from Ilia's review (thanks Ilia!).
Repository:
rL LLVM
http://reviews.llvm.org/D15593
Files:
packages/Python/lldbsuite/test/help/TestHelp.py
packages/Pyth
dawn marked 6 inline comments as done.
dawn added a comment.
> clang-format your changes please (there are many deviations from the coding
> style)
I've made some fixes even though the code is no longer consistent with the rest
of the file. Alas. I would love to run all of lldb through clang
ki.stfu added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-mi/symbol/symbol_list_lines_inline_test.h:20
@@ -19,3 +19,3 @@
{
-return a + b;
+return a + b; // FUNC_mfunc
}
and could you pick it up at 1 line above?
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
clang-format your changes please (there are many deviations from the coding
style)
I'll check it on Linux and say if everything is OK.
Comment at: source/Command
dawn retitled this revision from "Add "target modules dump line-entries "
command and use it to fix MI's -symbol-list-lines." to "Enhance "target modules
dump line " and use it to fix MI's -symbol-list-lines.".
dawn updated the summary for this revision.
dawn updated this revision to Diff 43103.
15 matches
Mail list logo
