[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

2023-07-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rG12f3d97fc68b:

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

2023-07-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:508 ctf_record.name.data(), tag_kind, eLanguageTypeC); +

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

2023-07-28 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added a comment. Generally LGTM, just some clarifications questions Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:508 ctf_record.name.data(), tag_kind, eLanguageTypeC); +

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

2023-07-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Support recursive record types in CTF. We are now more lazy when creating LLDB types. When encountering a record