[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f092f37b736: [llvm] Extract common `OptTable` bits into macros (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added inline comments. Comment at: lld/ELF/Driver.h:28 OPT_INVALID = 0, -#define OPTION(_1, _2, ID, _4, _5, _6, _7, _8, _9, _10, _11, _12) OPT_##ID, +#define OPTION(...) LLVM_MAKE_OPT_ID(__VA_ARGS__), #include "Options.inc" MaskRay wrote: >

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547090. jansvoboda11 added a comment. Herald added subscribers: pmatos, asb, aheejin, sbc100. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. Convert missed LLD parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay added inline comments. Comment at: lld/ELF/Driver.h:28 OPT_INVALID = 0, -#define OPTION(_1, _2, ID, _4, _5, _6, _7, _8, _9, _10, _11, _12) OPT_##ID, +#define OPTION(...) LLVM_MAKE_OPT_ID(__VA_ARGS__), #include "Options.inc" lld/wasm lld/COFF

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D157028#4558724 , @jansvoboda11 wrote: > Here's an example of a patch that changes the `OPTION` macro: D157029 >

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547018. jansvoboda11 added a comment. Herald added a reviewer: alexander-shaposhnikov. Consolidate all usages by extra `_WITH_ID_PREFIX` macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added a comment. Here's an example of a patch that changes the `OPTION` macro: D157029 . I wonder if we could have counterparts to `LLVM_MAKE_OPT_ID` and `LLVM_CONSTRUCT_OPT_INFO` that allow overriding the default `OPT_` prefix. That would make

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

MaskRay added a comment. I'll be away for a few days but I took a quick glance. This change looks reasonable. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/ https://reviews.llvm.org/D157028

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 created this revision. jansvoboda11 added a reviewer: MaskRay. Herald added subscribers: jhenderson, ormris, ributzka, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a project: All. jansvoboda11