[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi added a comment. In D157059#4572809 , @Michael137 wrote: > Hi, this is failing on swift-ci (runs on x86 bots) with the following error: > > > /Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdli

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

Michael137 added a comment. Hi, this is failing on swift-ci (runs on x86 bots) with the following error: /Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdlib-Release/lldb-macosx-x86_64/unittests/ObjectFile/PECOFF/./ObjectFilePECOFFTests --gtest_f

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hjyamauchi marked an inline comment as done. Closed by commit rGe9040e875d92: [lldb][PECOFF] Exclude alignment padding when reading section data (authored by hjyamauchi

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi marked an inline comment as done. hjyamauchi added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1035 + // llvm::object::COFFObjectFile::getSectionSize(). + if (m_binary->getDOSHeader()) +return std::min(section->GetByteS

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi updated this revision to Diff 547272. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157059/new/ https://reviews.llvm.org/D157059 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/source/Plugins/ObjectFile/PECOFF/

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

MrTrillian accepted this revision. MrTrillian added a comment. Looking good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157059/new/ https://reviews.llvm.org/D157059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM outside of the PE header check. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1035 + // llvm::object::COFFObjectFile::getSectionSize(). +

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi updated this revision to Diff 547086. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157059/new/ https://reviews.llvm.org/D157059 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/source/Plugins/ObjectFile/PECOFF/

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

hjyamauchi created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. hjyamauchi requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. There can be zero padding bytes at a section end for file alig