sas closed this revision.
sas added a comment.
Committed as r257204.
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
Great, thanks!
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci updated this revision to Diff 44361.
fjricci added a comment.
Disable exception trapping by default on all functions in InferiorCallPOSIX
http://reviews.llvm.org/D15978
Files:
source/Plugins/Process/Utility/InferiorCallPOSIX.cpp
source/Plugins/Process/Utility/InferiorCallPOSIX.h
In
fjricci added a comment.
Sounds good, will do.
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
If you don't mind, please add the same code to the InferiorCallMunmap, and then
add the same thing to InferiorCall, but that's the one that should take a
parameter in case somebody does end up using the general function for something
that could throw. Otherwise we'll j
fjricci added a comment.
Would you still like me to make the parameter change to InferiorCallMmap before
merging?
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
fjricci added a comment.
@jingham - your suggestion does avoid the recursion as well, and seems a lot
cleaner.
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
fjricci created this revision.
fjricci added reviewers: clayborg, jingham.
fjricci added subscribers: lldb-commits, sas.
When we construct AppleObjCTrampolineHandler, if m_impl_fn_addr is invalid, we
call CanJIT(). If the gdb remote process does not support allocating and
deallocating memory, th
fjricci added a comment.
Here's a paste of the end of the backtrace.
pastebin.com/3VkF3Biq
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci updated this revision to Diff 44305.
fjricci added a comment.
Follow suggestion by @jingham to avoid setting up ObjC runtime for low-level
POSIX memory allocations
http://reviews.llvm.org/D15978
Files:
source/Plugins/Process/Utility/InferiorCallPOSIX.cpp
Index: source/Plugins/Proces
jingham added a comment.
Cool! For completeness I think it is a good idea to do this to all the
functions in InferiorCallPOSIX. For the general InferiorCall one it might be a
good idea to add a defaulted (to false) parameter so that if somebody really
needs to use it for something that might
jingham added a comment.
That penultimate sentence would be clearer if I had put the end ")" in the
right place - after "recursion"
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
jingham added a comment.
Ah, right. We're doing that so that we can make sure that an ObjC Exception
thrown during the course of expression evaluation doesn't unwind past the frame
we are using to call the function.
Seems like for low-level stuff like AllocateMemory we should be avoiding all
jingham added a comment.
Can you post the backtrace in this case? It seems to me odd that CanJIT ->
AllocateMemory needs to construct the AppleObjCRuntime to do its job. I'd
rather cut the chain at that point if it makes sense.
http://reviews.llvm.org/D15978
__
14 matches
Mail list logo
