Re: [Lldb-commits] [PATCH] D16186: Unconditionally accept symbol sizes from elf

2016-01-18 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258040: Unconditionally accept symbol sizes from elf (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D16186?vs=44981&id=45160#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D16186: Unconditionally accept symbol sizes from elf

2016-01-15 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Never mind, sorry, missed that this was in Symbol.cpp, I was still thinking of the ObjectFileELF... http://reviews.llvm.org/D16186 ___ lldb-

Re: [Lldb-commits] [PATCH] D16186: Unconditionally accept symbol sizes from elf

2016-01-15 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Symbol/Symtab.cpp:974-978 @@ -973,5 +973,7 @@ Symbol &symbol = m_symbols[entry.data]; - -symbol.SetByteSize(end_section_file_addr - symbol_file_addr); -s

Re: [Lldb-commits] [PATCH] D16186: Unconditionally accept symbol sizes from elf

2016-01-15 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Symbol/Symtab.cpp:974-978 @@ -973,5 +973,7 @@ Symbol &symbol = m_symbols[entry.data]; - -

Re: [Lldb-commits] [PATCH] D16186: Unconditionally accept symbol sizes from elf

2016-01-15 Thread Tamas Berghammer via lldb-commits
tberghammer retitled this revision from "Unconditionally accept symbol sizes from .dynsym" to "Unconditionally accept symbol sizes from elf". tberghammer updated the summary for this revision. tberghammer updated this revision to Diff 44981. tberghammer added a comment. I disabled the symbol size