Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

2016-02-05 Thread Muhammad Omair Javaid via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259885: Add support to detect arm hard float ABI based binaries for ABISysV_arm (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D16627?vs=46620=47014#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

2016-01-27 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with a few nits inline Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:418 @@ +417,3 @@ +bool +ABISysV_arm::IsArmHardFloat (Thread *thread) const

Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

2016-01-27 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Change over to use a "Thread &" as argument to "bool ABISysV_arm::IsArmHardFloat(Thread *)" and this is good to go. http://reviews.llvm.org/D16627

[Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

2016-01-27 Thread Muhammad Omair Javaid via lldb-commits
omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds logic to detect if underlying binary is using arm hard float abi and use that information while handling