This revision was automatically updated to reflect the committed changes.
Closed by commit rL259885: Add support to detect arm hard float ABI based
binaries for ABISysV_arm (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D16627?vs=46620&id=47014#toc
Repository:
rL LL
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid updated this revision to Diff 46620.
omjavaid marked 4 inline comments as done.
omjavaid added a comment.
Updated after addressing concerns.
LGTM?
http://reviews.llvm.org/D16627
Files:
include/lldb/Core/ArchSpec.h
source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp
source/Plugins/ABI/Sy
clayborg added a comment.
And fix all of the tberghammer's comments as well.
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Change over to use a "Thread &" as argument to "bool
ABISysV_arm::IsArmHardFloat(Thread *)" and this is good to go.
http://reviews.llvm.org/D16627
___
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with a few nits inline
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:418
@@ +417,3 @@
+bool
+ABISysV_arm::IsArmHardFloat (Thread *thread) const
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This patch adds logic to detect if underlying binary is using arm hard float
abi and use that information while handling return