tfiala added a comment.
In http://reviews.llvm.org/D16769#342073, @tfiala wrote:
> In http://reviews.llvm.org/D16769#342069, @tfiala wrote:
>
> > This needs to be reverted. We've got 92 tests failing when this hit:
> >
> > http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
>
>
> I'm in th
tfiala added a comment.
In http://reviews.llvm.org/D16769#342069, @tfiala wrote:
> This needs to be reverted. We've got 92 tests failing when this hit:
>
> http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
I'm in the process of testing the issues go away with the revert. I'll commit
tfiala added a subscriber: tfiala.
tfiala added a comment.
This needs to be reverted. We've got 92 tests failing when this hit:
http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
Repository:
rL LLVM
http://reviews.llvm.org/D16769
___
lld
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259538: [NFC] Cleanup RangeMap.h (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16769?vs=46531&id=46673#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16769
Files:
clayborg added a comment.
No need to revert anything as these classes are stable now and don't need
debugging. Just something to be aware of in other cases when you make future
changes.
http://reviews.llvm.org/D16769
___
lldb-commits mailing list
tberghammer added a comment.
In http://reviews.llvm.org/D16769#340936, @clayborg wrote:
> Looks fine. A few things I don't like, but I can live with:
>
> - Making constructors appear all on one line does save space, but it means
> you can't debug very well as stepping into these constructors wil
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. A few things I don't like, but I can live with:
- Making constructors appear all on one line does save space, but it means you
can't debug very well as stepping into these cons
tberghammer created this revision.
tberghammer added reviewers: clayborg, labath.
tberghammer added a subscriber: lldb-commits.
[NFC] Cleanup RangeMap.h
The file contained very similar 4 implementation of the same data
structure with a lot of duplicated code and some minor API differences.
This C
