This revision was automatically updated to reflect the committed changes.
Closed by commit rL259509: Fix single stepping over the IT instruction
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16772?vs=46542=46647#toc
Repository:
rL LLVM
tberghammer added a comment.
In http://reviews.llvm.org/D16772#340950, @clayborg wrote:
> Looks good.
>
> A related comment about IT instructions. You need to be careful when software
> single stepping through instructions that are in the middle of an ITSTATE
> block. You can NOT use a 16 bit
clayborg added a comment.
In http://reviews.llvm.org/D16772#341629, @tberghammer wrote:
> In http://reviews.llvm.org/D16772#340950, @clayborg wrote:
>
> > Looks good.
> >
> > A related comment about IT instructions. You need to be careful when
> > software single stepping through instructions
clayborg added a comment.
Looks good.
A related comment about IT instructions. You need to be careful when software
single stepping through instructions that are in the middle of an ITSTATE
block. You can NOT use a 16 bit instruction that isn't a BKPT otherwise you
change your instructions.
omjavaid accepted this revision.
omjavaid added a comment.
Looks good. Was there a test failing in testsuite due to this?
http://reviews.llvm.org/D16772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
