Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-16 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer added a comment. Hi Ewan, Can you give me some instruction about how can I reproduce the issue on a Nexus 6? (If you can't gave the information out then the disassembly of the offending function and the fault address might gave me some hint

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-16 Thread Tamas Berghammer via lldb-commits
Hi Ewan, Can you give me some instruction about how can I reproduce the issue on a Nexus 6? (If you can't gave the information out then the disassembly of the offending function and the fault address might gave me some hint as well) A SIGBUS error looks a bit strange for me but my best guess is t

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-16 Thread Ewan Crawford via lldb-commits
EwanCrawford added a subscriber: EwanCrawford. EwanCrawford added a comment. Hi Tamas, This commit causes a SIGBUS for me on Nexus 6 ARMv7 devices, specifically the g_thumb_breakpoint_opcode change. I can revert this locally but any advice on tracking the issue down further? Repository: rL L

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-10 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260367: Use BKPT instead of UDF for arm/thumb breakpoints (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D16853?vs=46899&id=47431#toc Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-09 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Most JTAG probes actually vend their own GDB server these days. If so, we will used the Z packets in order to set breakpoints, so we will be isolated from these issues. If we a

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. In http://reviews.llvm.org/D16853#347120, @omjavaid wrote: > GDB doesnt use bkpt instruction for user debugging for the reason that it > interferes with jtag debug probes. I am not sure if LLDB will be ever used > with a jtag probe in near future but still a jtag pr

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-09 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. GDB doesnt use bkpt instruction for user debugging for the reason that it interferes with jtag debug probes. I am not sure if LLDB will be ever used with a jtag probe in near future but still a jtag prob might be connected to the same hardware which is using LLDB to de

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-04 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 46899. tberghammer added a comment. Update breakpoint opcodes based on review http://reviews.llvm.org/D16853 Files: source/Plugins/Platform/Linux/PlatformLinux.cpp source/Plugins/Process/Linux/NativeProcessLinux.cpp Index: source/Plugins/Process/Li

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-03 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. There are immediate values you can play around with inside the BKPT instruction of both ARM and Thumb versions so that the two least significant bytes are the same: static const

[Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-03 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: clayborg, omjavaid. tberghammer added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Use BKPT instead of UDF for arm/thumb breakpoints The UDF instruction is deprecated in armv7 and in case of thumb2 instru