Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D16900#344702, @sivachandra wrote: > Thanks a lot Todd. I will put this in tomorrow morning just to be on the > safer side. My pleasure, Siva! http://reviews.llv

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Siva Chandra via lldb-commits
sivachandra added a comment. Thanks a lot Todd. I will put this in tomorrow morning just to be on the safer side. http://reviews.llvm.org/D16900 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Todd Fiala via lldb-commits
This tested cleanly, no failures on OS X. Lgtm. -Todd > On Feb 4, 2016, at 2:15 PM, Todd Fiala wrote: > > tfiala added a comment. > > I'm going to try this out now > > > http://reviews.llvm.org/D16900 > > > ___ lldb-commits mailing list lldb-com

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Todd Fiala via lldb-commits
tfiala added a comment. I'm going to try this out now http://reviews.llvm.org/D16900 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Siva Chandra via lldb-commits
sivachandra added inline comments. Comment at: source/Expression/ExpressionSourceCode.cpp:188 @@ +187,3 @@ +ConstString var_name = var_sp->GetName(); +if (var_name == ConstString("this") || var_name == ConstString(".block_descriptor")) +continue; -

[Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added reviewers: spyffe, tfiala. sivachandra added a subscriber: lldb-commits. This relands r259810 with fix for failures on Mac. http://reviews.llvm.org/D16900 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerDeclContext