Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-10 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260369: Improve the handling of missing elf symtab and missing symbol sizes (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D16996?vs=47314=47433#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 47314. http://reviews.llvm.org/D16996 Files: include/lldb/Core/RangeMap.h include/lldb/Symbol/DWARFCallFrameInfo.h include/lldb/Symbol/ObjectFile.h include/lldb/Symbol/Symtab.h source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2939 @@ +2938,3 @@ +symbol_id, // Symbol table index. +symbol_name, // Symbol name. +false,

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-09 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D16996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-08 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Improve the handling of missing elf symtab and missing symbol sizes * Generate artificial symbol names from eh_fame during symbol parsing so these symbols are already

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-08 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Make sure we use a consistent naming scheme for symbols that don't have names between all ObjectFile subclasses. Comment at: