Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-26 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 262011. Repository: rL LLVM http://reviews.llvm.org/D17131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-12 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D17131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-12 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 47776. nitesh.jain added a comment. Update the diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py Index: packages/Python/lldbsuit

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-12 Thread Nitesh Jain via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added a comment. Thanks zturner. Will update the diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-11 Thread Zachary Turner via lldb-commits
Not going to block the change over this, but just as an fyi, you can specify regexes without usign `re.compile`. You can literally just pass a string that is a regex, it will still work On Thu, Feb 11, 2016 at 11:22 PM Nitesh Jain via lldb-commits < lldb-commits@lists.llvm.org> wrote: > nitesh.j

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-11 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. Not going to block the change over this, but just as an fyi, you can specify regexes without usign `re.compile`. You can literally just pass a string that is a regex, it will still work Repository: rL LLVM http://reviews.llvm.org/

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-11 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 47767. nitesh.jain added a comment. Updated as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py Index: packages/Python/lldbsuite/test/f

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-11 Thread Oleksiy Vyalov via lldb-commits
ovyalov added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py:22 @@ -20,1 +21,3 @@ +# Backtracing failed due to lack of prolog/epilog informations in assert function of libc.so.6 +@expectedFailureAll(tripl

[Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-11 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The debug version of libc.so is require for backtracing which may n