spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
I'm concerned about the performance implications here, because
`FindBestAlternateMangledName` is invoked for every C++ symbol lookup, not just
for ones that would fail unless we did
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
Sean should be the one to OK this.
http://reviews.llvm.org/D17618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sivachandra updated this revision to Diff 49138.
sivachandra added a comment.
Add more gtest unittests.
http://reviews.llvm.org/D17618
Files:
include/lldb/Symbol/SymbolFile.h
packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py
packages/Python/lldbsuite/test/lang/cpp/stl/main.cpp
sivachandra updated this revision to Diff 49098.
sivachandra added a comment.
Fix a comment in file, fix formatting in another.
http://reviews.llvm.org/D17618
Files:
include/lldb/Symbol/SymbolFile.h
packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py
sivachandra created this revision.
sivachandra added reviewers: spyffe, clayborg.
sivachandra added a subscriber: lldb-commits.
This, in a way, extends the existing "workaroud" by matching function
argument type names individually [instead of just matching "(args1...)"
with "(args2...)"]. For