Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-07-11 Thread Sean Callanan via lldb-commits
spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. I'm concerned about the performance implications here, because `FindBestAlternateMangledName` is invoked for every C++ symbol lookup, not just for ones that would fail unless we did

Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-02-26 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. Sean should be the one to OK this. http://reviews.llvm.org/D17618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-02-25 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 49138. sivachandra added a comment. Add more gtest unittests. http://reviews.llvm.org/D17618 Files: include/lldb/Symbol/SymbolFile.h packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py packages/Python/lldbsuite/test/lang/cpp/stl/main.cpp

Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-02-25 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 49098. sivachandra added a comment. Fix a comment in file, fix formatting in another. http://reviews.llvm.org/D17618 Files: include/lldb/Symbol/SymbolFile.h packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py

[Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-02-25 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added reviewers: spyffe, clayborg. sivachandra added a subscriber: lldb-commits. This, in a way, extends the existing "workaroud" by matching function argument type names individually [instead of just matching "(args1...)" with "(args2...)"]. For