This revision was automatically updated to reflect the committed changes.
Closed by commit rL262255: Fix TestInlines.py on Windows (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D17650?vs=49208=49409#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17650
Files:
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/lang/cpp/inlines/inlines.h:1-4
@@ +1,4 @@
+int inner_inline (int inner_input, int mod_value);
+int outer_inline (int outer_input);
+int not_inlined_2 (int input);
+int not_inlined_1 (int input);
zturner added a comment.
I don't know where we draw the line between `test/lang` and
`test/functionalities` but I feel like the purpose of this test is just to make
sure LLDB has the general ability to handle setting breakpoints on inline call
sites. With that in mind, it make more sense to
amccarth created this revision.
amccarth added reviewers: zturner, spyffe.
amccarth added a subscriber: lldb-commits.
The inlining semantics for C and C++ are different, which affects the test's
expectation of the number of times the function should appear in the binary.
In the case of this
