Re: [Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

2016-03-01 Thread Ted Woodward via lldb-commits
ted updated this revision to Diff 49542. ted added a comment. Updated to address Sean's comments http://reviews.llvm.org/D17745 Files: include/lldb/Expression/IRInterpreter.h source/Expression/IRExecutionUnit.cpp source/Expression/IRInterpreter.cpp

Re: [Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

2016-02-29 Thread Sean Callanan via lldb-commits
spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Aside from one minor object ownership issue this is good to go. Change the `IRExecutionUnitSP` to an `IRExecutionUnit&` and you have my blessing! Comment at:

[Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

2016-02-29 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: spyffe. ted added a subscriber: lldb-commits. Recent changes to the expression parser broke function name resolution when using the IR interpreter instead of JIT. This patch changes the IRMemoryMap ivar in InterpreterStackFrame to an