This revision was automatically updated to reflect the committed changes.
Closed by commit rL265525: Fix a cornercase in breakpoint reporting (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D18692?vs=52357&id=52771#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1869
jingham accepted this revision.
jingham added a reviewer: jingham.
jingham added a comment.
Yes, that sounds right.
http://reviews.llvm.org/D18692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
labath added a comment.
In http://reviews.llvm.org/D18692#389529, @clayborg wrote:
> Looks fine. We should probably put the code that checks for a breakpoint at
> the thread PC into a function since it is done about 5 times in this function.
I'll prepare a follow-up to deduplicate the code her
jingham added a subscriber: jingham.
jingham added a comment.
The only worry I have about this is
- thread A is stopped at a breakpoint, and then we stop on thread B instead,
then we report a breakpoint, great!
- The user steps thread B, which we do by suspending thread B and stepping A.
- Then
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. We should probably put the code that checks for a breakpoint at the
thread PC into a function since it is done about 5 times in this function.
http://reviews.llvm.org/D18692
labath updated this revision to Diff 52357.
labath added a comment.
I've realized that some foreign stubs may not send the "reason" field, so I
limit the scope of this change to cases where "signal" is zero as well.
http://reviews.llvm.org/D18692
Files:
source/Plugins/Process/gdb-remote/Proc
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
This resolves a similar problem as D16720 (which handled the case when we
single-step onto a
breakpoint), but this one deals with involutary stops: when we stop a thread
(e.g. because
anothe
