Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

abidh added a comment. In http://reviews.llvm.org/D18880#395530, @zturner wrote: > Looks fine to me. TBH I haven't seen any of the lldb-mi owners around in > months, so I'm not sure if they're still active Sorry for late reply. I have been busy lately but keep an eye on lldb-mi patches. ht

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

ChuckR added a subscriber: ChuckR. ChuckR closed this revision. ChuckR added a comment. closed with http://reviews.llvm.org/rL265858 http://reviews.llvm.org/D18880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

zturner accepted this revision. zturner added a reviewer: zturner. zturner added a comment. This revision is now accepted and ready to land. Looks fine to me. TBH I haven't seen any of the lldb-mi owners around in months, so I'm not sure if they're still active http://reviews.llvm.org/D18880

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

jacdavis updated this revision to Diff 53031. jacdavis added a comment. last diff missed lldb-mi changes http://reviews.llvm.org/D18880 Files: packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/Makefile packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/TestMiThreadInfo.py packa

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

jacdavis updated this revision to Diff 53028. jacdavis added a comment. Ran formatting tool with lldb format. pthread linker option is still required for C++11 threads so left it in. New test still disabled for windows. http://reviews.llvm.org/D18880 Files: Makefile TestMiThreadInfo.py t

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

Great, thanks. I'll rerun in the morning. I realized I also left the pthread linker option on in the test. Sent from my Windows Phone From: Zachary Turner Sent: ‎4/‎7/‎2016 6:21 PM To: Jackson Davis;

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

zturner added a comment. We have an lldb style file in llvm/tools/lldb, it should be picked up automatically if you run it from the lldb directory. I'm not sure though if it's based on the folder you're in when you run clang-format or by searching up the tree from the target file until it finds a

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

We have an lldb style file in llvm/tools/lldb, it should be picked up automatically if you run it from the lldb directory. I'm not sure though if it's based on the folder you're in when you run clang-format or by searching up the tree from the target file until it finds a rule file On Thu, Apr 7, 2

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

jacdavis updated this revision to Diff 52991. jacdavis added a comment. Updated to use C++ 11 threads. Clang-format tried to format the diff in the llvm style. Since this is all lldb code, is that actually what is expected? None of the braces matched etc http://reviews.llvm.org/D18880 Fil

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

zturner added a subscriber: zturner. zturner added a comment. Hi Jackson, Two suggestions: 1. Please clang-format the patch. Let me know if you need help getting this working. 2. use C++11 threads instead of pthreads. This makes the tests portable to Windows. Even if the test still fails on

[Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

jacdavis created this revision. jacdavis added reviewers: lldb-commits, abidh. -thread-info in lldbmi does not conform to protocol. Should end with current thread id as described here: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Thread-Commands.html#GDB_002fMI-Thread-Commands When pri