This revision was automatically updated to reflect the committed changes.
Closed by commit rL266315: Fix test cases for big-endian systems (authored by
uweigand).
Changed prior to commit:
http://reviews.llvm.org/D18985?vs=53501&id=53714#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18985
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for updating the changes.
http://reviews.llvm.org/D18985
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
uweigand added a comment.
In http://reviews.llvm.org/D18985#397674, @clayborg wrote:
> So many tests above are going to accept either a little endian or big endian
> value. This will make most of these tests useless since if a little endian
> machine fails with a big endian number we won't catc
uweigand updated the summary for this revision.
uweigand updated this revision to Diff 53501.
http://reviews.llvm.org/D18985
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-python-synth/TestDataFormatterPythonSynth.py
packages/Python/lldbsuite/test/functi
uweigand added a comment.
In http://reviews.llvm.org/D18985#398171, @labath wrote:
> Just because the tests test the console interface, it doesn't mean you can't
> use the python interface to do auxiliary tasks, like computing the
> expectations. It sounds like you should be able to to a
> `se
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D18985#398169, @uweigand wrote:
> In http://reviews.llvm.org/D18985#397674, @clayborg wrote:
>
> > So many tests above are going to accept either a little endian or big
> > endian value. This will make most of
uweigand added a comment.
In http://reviews.llvm.org/D18985#397674, @clayborg wrote:
> So many tests above are going to accept either a little endian or big endian
> value. This will make most of these tests useless since if a little endian
> machine fails with a big endian number we won't catc
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So many tests above are going to accept either a little endian or big endian
value. This will make most of these tests useless since if a little endian
machine fails with a big e
uweigand created this revision.
uweigand added reviewers: granata.enrico, clayborg.
uweigand added a subscriber: lldb-commits.
A number of test cases were failing on big-endian systems simply due to
byte order assumptions in the tests themselves, and no underlying bug
in LLDB.
These two test case
