Re: [Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

2016-04-12 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL266145: Fix breakpoint_set_restart test for Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19035?vs=53472&id=53482#toc Repo

Re: [Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

2016-04-12 Thread Adrian McCarthy via lldb-commits
amccarth marked an inline comment as done. Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11 @@ -10,2 +10,3 @@ +#include #include #include ovyalov wrote: > You may remove iostream since getchar is no lon

Re: [Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

2016-04-12 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11 @@ -10,2 +10,3 @@ +#include #include #include You may remove iostream si

[Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

2016-04-12 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added reviewers: ovyalov, labath. amccarth added a subscriber: lldb-commits. When run with the multiprocess test runner, the getchar() trick doesn't work, so `ninja check-lldb` would fail on this test, but running the test directly worked fine. This repl