cameron314 created this revision.
cameron314 added a reviewer: spyffe.
cameron314 added subscribers: mamai, lldb-commits.
cameron314 set the repository for this revision to rL LLVM.
This allows expressions such as 'i == 1 || i == 2` to be executed using the IR
interpreter.
Repository:
rL LLVM
I'll let Sean comment on the content of the patch, but please add a test
that runs such an expression and demonstrates the correct output.
On Thu, Apr 14, 2016 at 10:01 AM Cameron via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> cameron314 created this revision.
> cameron314 added a revie
zturner added a subscriber: zturner.
zturner added a comment.
I'll let Sean comment on the content of the patch, but please add a test
that runs such an expression and demonstrates the correct output.
Repository:
rL LLVM
http://reviews.llvm.org/D19124
__
cameron314 added a comment.
Ah, that's a bit tricky at the moment. The LLVM tip no longer compiles with
VS2015 (specifically lib\Support\SourceMgr.cpp), and my Python setup for VS2013
is all wonky.
This will have to wait a bit.
Repository:
rL LLVM
http://reviews.llvm.org/D19124
_
http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015
My build bot which uses MSVC 2015 is workign fine. What kind of error are
you seeing?
On Thu, Apr 14, 2016 at 10:14 AM Cameron wrote:
> cameron314 added a comment.
>
> Ah, that's a bit tricky at the moment. The LLVM tip no longer comp
cameron314 added a comment.
Whoops, my fault. I was accidentally using the VS2013 command prompt with the
2015 cmake files. Compiling happily as we speak, test coming up soon after.
Repository:
rL LLVM
http://reviews.llvm.org/D19124
___
lldb-com
cameron314 removed rL LLVM as the repository for this revision.
cameron314 updated this revision to Diff 54134.
cameron314 added a comment.
I've added a test for this patch.
http://reviews.llvm.org/D19124
Files:
packages/Python/lldbsuite/test/expression_command/ir-interpreter/Makefile
pack
cameron314 added a comment.
I'd appreciate if someone could take a look at this when they have a moment.
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
This is going to have to be Sean, but his delay can be unpredictable. Keep
pinging every so often until you get a response
On Thu, Apr 28, 2016 at 2:41 PM Cameron wrote:
> cameron314 added a comment.
>
> I'd appreciate if someone could take a look at this when they have a
> moment.
>
>
> http://r
cameron314 added a comment.
All right, no worries :-) I didn't want to bother anyone.
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cameron314 added a comment.
@spyffe, do you have time to look at this sometime this week? It's a very
simple patch (the test code took longer to write than the patch itself). Thanks!
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb
spyffe added a subscriber: spyffe.
spyffe added a comment.
Ah… you know me too well.
Looking at this now.
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
This patch is fine. I especially appreciate the time you took making the
IRInterpreter properly testable. I will use this myself.
Comment at: source/Commands/CommandObjectE
cameron314 added a comment.
Excellent, thank you!
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269340: [LLDB] Added support for PHI nodes to IR interpreter
(authored by mamai).
Changed prior to commit:
http://reviews.llvm.org/D19124?vs=54134&id=57093#toc
Repository:
rL LLVM
http://reviews.llv
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
Looks like this CL broke CMake build bot -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14634,
could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D19124
__
Note that while adding a "expr --allow-jit" flag to control this was great,
there already was an SBExpressionOptions option and the appropriate flags
available for this, so it was testable. I was just checking because there
really shouldn't be anything we can do from a command that we can't do
Sorry to break the build! Apparently 'make clean' isn't executing cleanly
during the build step of the test, but I haven't the faintest idea why. It
builds/runs fine locally for me (then again, I'm on Windows). The makefile
is dead simple, and is identical to that of some other tests. Has anyone
se
> On May 12, 2016, at 2:25 PM, Cameron wrote:
>
> Sorry to break the build! Apparently 'make clean' isn't executing cleanly
> during the build step of the test, but I haven't the faintest idea why. It
> builds/runs fine locally for me (then again, I'm on Windows). The makefile is
> dead simpl
Thanks Jim, I'll definitely use that as a template next time!
Ah, I think I found the problem with the test. The makefile was in the
patch but wasn't committed. Trying that out now.
On Thu, May 12, 2016 at 5:45 PM, Jim Ingham wrote:
>
> > On May 12, 2016, at 2:25 PM, Cameron wrote:
> >
> > Sor
I added the makefile with r269366. The tests seem to be working now:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14641
Sorry about that!
On Thu, May 12, 2016 at 6:07 PM, Cameron wrote:
> Thanks Jim, I'll definitely use that as a template next time!
>
> Ah, I think I f
21 matches
Mail list logo
