This revision was automatically updated to reflect the committed changes.
Closed by commit rL267405: Handle invalid values of PLT entry size generated by
linker (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D19252?vs=54146=54845#toc
Repository:
rL LLVM
tberghammer accepted this revision.
tberghammer added a comment.
I don't really have an opinion about CheckPLTSize() function Greg proposes but
I definitely want to see some comment explaining why we say that a plt entry
less then 4 byte is invalid.
http://reviews.llvm.org/D19252
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
As long as PLT entries can't possibly be 4 bytes, then this is OK. Another way
to fix this would be to make a "CheckPLTSize()" function that checks the
architecture of the file, or just
omjavaid created this revision.
omjavaid added reviewers: tberghammer, rengolin, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
This patch provides a fix for wrong plt entry size generated for binaries built
with gcc and
