Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. > Then we need to introduce a 64 bit atomic check in > cmake/modules/LLDBStandalone.cmake. What do you think? > > Thanks I think this should be right solution. Repository: rL LLVM http://reviews.llvm.org/D20464 _

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#473884, @Eugene.Zelenko wrote: > As fas as I could judge from log, you built LLDB with LLVM/Clang. But problem > happens when it's necessary to build LLDB separately from LLVM/Clang > (standalone build). Then we need to introduce

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. As fas as I could judge from log, you built LLDB with LLVM/Clang. But problem happens when it's necessary to build LLDB separately from LLVM/Clang (standalone build). Repository: rL LLVM http://reviews.llvm.org/D20464 __

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#472733, @Eugene.Zelenko wrote: > I run CMake with --trace and is mentioned only in condition added there. I have attach log of CMake with --trace. F2135359: log Repository: rL LLVM http://rev

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. I run CMake with --trace and is mentioned only in condition added there. Repository: rL LLVM http://reviews.llvm.org/D20464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#471803, @Eugene.Zelenko wrote: > I see HAVE_CXX_ATOMICS64_WITHOUT_LIB messages during LLVM Cmake run, but I > don't see such message during LLDB CMake run. > > Is this value is supposed to be read form LLVM CMake cache? Yes. Repo

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. I see HAVE_CXX_ATOMICS64_WITHOUT_LIB messages during LLVM Cmake run, but I don't see such message during LLDB CMake run. Is this value is supposed to be read form LLVM CMake cache? Repository: rL LLVM http://reviews.llvm.org/D20464

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#470527, @Eugene.Zelenko wrote: > This change broke standalone build. Looks like check which should set > HAVE_CXX_ATOMICS64_WITHOUT_LIB was not performed. > > I build LLDB with LLVM STL which doesn't have libatomic. The CheckAtomi

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This change broke standalone build. Looks like check which should set HAVE_CXX_ATOMICS64_WITHOUT_LIB was not performed. I build LLDB with LLVM STL which doesn't have libatomic. Repository: rL LLVM http://rev

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, thanks. Repository: rL LLVM http://reviews.llvm.org/D20464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.o

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain updated this revision to Diff 61940. nitesh.jain added a comment. Thanks Labath. Updated diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D20464 Files: cmake/LLDBDependencies.cmake Index: cmake/LLDBDependencies.cmake =

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. In general, the idea sounds reasonable. I think you should be able to achieve the same effect by adding the library to LLDB_SYSTEM_LIBS in LLDBDependencies.cmake. This should be a mu