Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL270854: [cmake] Add a big warning about a libstdc++ issue (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20671?vs=58584&id=58616#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

Ok, lgtm then On Thu, May 26, 2016 at 7:46 AM Pavel Labath wrote: > labath added a comment. > > In http://reviews.llvm.org/D20671#440868, @zturner wrote: > > > Wondering if this should go in llvm. What do you think? > > > I don't see any uses of weak_ptr in the llvm repository, so this issue > sh

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

zturner added a comment. Ok, lgtm then http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath added a comment. In http://reviews.llvm.org/D20671#440868, @zturner wrote: > Wondering if this should go in llvm. What do you think? I don't see any uses of weak_ptr in the llvm repository, so this issue should only affect lldb, I think. http://reviews.llvm.org/D20671 _

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

Wondering if this should go in llvm. What do you think? On Thu, May 26, 2016 at 7:31 AM Tamas Berghammer via lldb-commits < lldb-commits@lists.llvm.org> wrote: > tberghammer accepted this revision. > tberghammer added a comment. > This revision is now accepted and ready to land. > > looks good > >

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

zturner added a subscriber: zturner. zturner added a comment. Wondering if this should go in llvm. What do you think? http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. looks good Comment at: cmake/modules/LLDBConfig.cmake:432 @@ +431,3 @@ +message(WARNING +"You appear to be using linking to libstdc++ version les

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

emaste added a comment. FreeBSD 10.0 and later uses libc++. FreeBSD 9 has a very old libstdc++ and a very old gcc and can't build Clang 3.5 or later with the system compiler anyway. So this isn't a problem for FreeBSD. I don't know cmake well enough to approve the change but the idea definitely

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

krytarowski added a comment. NetBSD is using newer libstdc++. #include std::set s = std::set(std::allocator()); int main() { return 0; } Compiles (I need to specify the -std=c++11 option) and runs. I will try it out in the context of LLDB CMake scripts. http://reviews.llvm.org/D20671

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath added a comment. I am adding everyone I think could be susceptible to this problem. It would be a good idea to check if you are still using libstdc++4.8 or older. http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath created this revision. labath added reviewers: tberghammer, tfiala, nitesh.jain, omjavaid, emaste, krytarowski. labath added a subscriber: lldb-commits. Recent increase in the usage of std::weak_ptr has caused us to rediscover an issue in libstdc++ versions prior to 4.9