This revision was automatically updated to reflect the committed changes.
Closed by commit rL270863: [cmake] Remove the LLDB versions of the
exception-controlling variables (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D20673?vs=58587&id=58630#toc
Repository:
rL LLVM
Don't think this is needed anymore, lgtm
On Thu, May 26, 2016 at 8:59 AM Todd Fiala wrote:
> tfiala added a comment.
>
> In http://reviews.llvm.org/D20673#440967, @labath wrote:
>
> > In http://reviews.llvm.org/D20673#440660, @labath wrote:
> >
> > > Enabling this should not make any difference i
tfiala added a comment.
In http://reviews.llvm.org/D20673#440967, @labath wrote:
> In http://reviews.llvm.org/D20673#440660, @labath wrote:
>
> > Enabling this should not make any difference in the common case, as llvm
> > already adds one set of exception-disabling flags if you don't specify th
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
This looks fine to me. ( http://reviews.llvm.org/D20671 also looked fine,
looks like I missed looking at that yesterday).
Since Zachary initially wanted this on Windows, I suspect he needs to
labath added a comment.
In http://reviews.llvm.org/D20673#440660, @labath wrote:
> Enabling this should not make any difference in the common case, as llvm
> already adds one set of exception-disabling flags if you don't specify the
> flag I mentioned (llvm/cmake/modules/AddLLVM.cmake).
(And
tfiala added a comment.
Having a look now. I don't recall the context yet.
http://reviews.llvm.org/D20673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Zachary, Todd, you added these in http://reviews.llvm.org/D3929. I know it's a
long time, but do you recall what was the original motivation for that?
In light of the issue in http://reviews.llvm.org/D20671, I've experimenting
with compiling lldb with exceptions enabled,
labath created this revision.
labath added reviewers: zturner, tfiala.
labath added a subscriber: lldb-commits.
One can still use the LLVM variables to control this: LLVM_ENABLE_EH,
LLVM_ENABLE_RTTI. It's not
clear to me why one would want to control these at lldb level and it's
generally not ev
