tfiala closed this revision.
tfiala added a comment.
Closed by commit r271312.
http://reviews.llvm.org/D20722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala marked 2 inline comments as done.
tfiala added a comment.
Marked comments as done.
http://reviews.llvm.org/D20722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala updated this revision to Diff 59105.
tfiala added a comment.
Updates per Greg.
- Args::Dump(stream, label) now takes a default label.
- Dropped the Args::Dump(stream) call.
- Converted the Args stream parameter to a ref. It is not valid to call this
without a stream.
- Updated in-source
tfiala added inline comments.
Comment at: include/lldb/Interpreter/Args.h:120
@@ -100,3 +119,3 @@
void
-Dump (Stream *s);
+Dump (Stream *s, const char *label_name) const;
clayborg wrote:
> I would make just one Dump function and default the label_na
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: include/lldb/Interpreter/Args.h:120
@@ -100,3 +119,3 @@
void
-Dump (Stream *s);
+Dump (Stream *s, const char *labe
tfiala added a comment.
This was the logging I used to discover the breakage in launching debugserver
from 'lldb-server platform' on Apple platforms.
http://reviews.llvm.org/D20722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
tfiala updated this revision to Diff 58751.
tfiala added a comment.
Fixed up whatever my arcanist-foo did wrong on the initial 'arc diff' creation
of the patch. (The diff I'm putting up is exactly what comes out of 'git diff
origin/master', so not sure how this got mutated into the original dif
tfiala added a comment.
Hang on, this diff is busted. It seems to have a few more changes in it than
came from me. (I suspect it is something slightly out of sync between my
change branch and trunk... I'll re-upload as soon as I straighten that out).
http://reviews.llvm.org/D20722
___
tfiala created this revision.
tfiala added reviewers: clayborg, labath, ovyalov.
tfiala added a subscriber: lldb-commits.
This change implements dumping the executable, triple,
args and environment when using ProcessInfo::Dump().
It also tweaks the way Args::Dump() works so that it prints
a confi
