This revision was automatically updated to reflect the committed changes.
Closed by commit rL272916: Allow installing watchpoints at less than 8-byte
alligned addresses for… (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D21280?vs=60942=60987#toc
Repository:
rL
omjavaid marked 3 inline comments as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_size/TestWatchpointSizes.py:104
@@ +103,3 @@
+self.expect("watchpoint list -v",
+substrs = ['hit_count = 2'])
+
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks for adding the test. I have some nits about some details of the test. If
you agree with them, you can commit the updated version without additional
review.
Comment
omjavaid updated this revision to Diff 60942.
omjavaid added a comment.
Herald added a subscriber: srhines.
I have added a test cases that tests all possibilities supported by current
configuration.
Tests pass on Nexus 9 and aarch64-linux-gnu (hikey board).
LGTM?
omjavaid added a comment.
In http://reviews.llvm.org/D21280#457196, @labath wrote:
> The overall change looks good, but please also add a test which specifically
> tests for watchpoints at unaligned addresses. Last time I checked, we all
> watchpoint tests were passing (at least on android)
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
The overall change looks good, but please also add a test which specifically
tests for watchpoints at unaligned addresses. Last time I checked, we all
watchpoint tests were passing
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Does this patch handle being able to share an 8 byte watchpoint between two
watchpoints? Lets say you have an 8 byte array named "a" and watch to watch
a[0] and a[3] and a[7]. You should
omjavaid created this revision.
omjavaid added reviewers: labath, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
This patch adds logic to make sure we can install watchpoints at 1,2 and 4 byte
alligned addresses.
ptrace
