Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Michał Górny via lldb-commits
mgorny added a comment. That won't work since it would require source dir to be still available when building LLDB. The point of stand-alone build is to avoid that, and after applying this patch (and the regex fix), I'm able to achieve that. Using LLVM_MAIN_SRC_DIR would be a regression. Repo

Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Michał Górny via lldb-commits
mgorny added a comment. In https://reviews.llvm.org/D23881#525411, @krytarowski wrote: > In https://reviews.llvm.org/D23881#525405, @mgorny wrote: > > > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote: > > > > > The proper way to fix it is to install CheckAtomic from LLVM/Clang. > >

Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Michał Górny via lldb-commits
mgorny added a comment. In https://reviews.llvm.org/D23881#525401, @krytarowski wrote: > The proper way to fix it is to install CheckAtomic from LLVM/Clang. > > See https://reviews.llvm.org/D22999 Wasn't that rejected? Repository: rL LLVM https://reviews.llvm.org/D23881

Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23881#525420, @mgorny wrote: > In https://reviews.llvm.org/D23881#525411, @krytarowski wrote: > > > In https://reviews.llvm.org/D23881#525405, @mgorny wrote: > > > > > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote: > > > >

Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23881#525405, @mgorny wrote: > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote: > > > The proper way to fix it is to install CheckAtomic from LLVM/Clang. > > > > See https://reviews.llvm.org/D22999 > > > Wasn't that rejected?

Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. The proper way to fix it is to install CheckAtomic from LLVM/Clang. See https://reviews.llvm.org/D22999 Repository: rL LLVM https://reviews.llvm.org/D23881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht