Re: [Lldb-commits] [PATCH] D24694: [LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings

2016-09-20 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282041: Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings in… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24694?vs=71718=72002#toc Repository:

Re: [Lldb-commits] [PATCH] D24694: [LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings

2016-09-20 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added inline comments. Comment at: source/Plugins/Process/Utility/RegisterInfos_x86_64.h:12 @@ -12,1 +11,3 @@ +#include +#include labath wrote: > It's not a "C" include, if it's cstddef now. :) If you could you also move > the headers to the

Re: [Lldb-commits] [PATCH] D24694: [LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings

2016-09-20 Thread Pavel Labath via lldb-commits
labath accepted this revision. Comment at: source/Plugins/Process/Utility/RegisterInfos_x86_64.h:12 @@ -12,1 +11,3 @@ +#include +#include It's not a "C" include, if it's cstddef now. :) If you could you also move the headers to the end of the include list as

[Lldb-commits] [PATCH] D24694: [LLDB] Fix Clang initialization and Clang-tidy modernize-use-nullptr warnings

2016-09-16 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: labath, zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Looks like RegisterContextNetBSD_x86_64.cpp should use RegisterInfos_x86_64.h as much as