[Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-11-12 Thread Sylvestre Ledru via lldb-commits
sylvestre.ledru added a comment. Can we land this patch now? Thanks Repository: rL LLVM https://reviews.llvm.org/D24863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-10-03 Thread Pablo Oliveira via lldb-commits
pablooliveira added a comment. > If you are fine with having lldb-server link against libLLVM in the > LLVM_LINK_LLVM_DYLIB case, I can make an lldb-only change that makes it work. > It won't affect our use case as we don't use that flag. @labath, I think that would be fine in the context of

[Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-10-03 Thread Pavel Labath via lldb-commits
labath added a comment. @pablooliveira @sylvestre.ledru : If you are fine with having lldb-server link against libLLVM in the LLVM_LINK_LLVM_DYLIB case, I can make an lldb-only change that makes it work. It won't affect our use case as we don't use that flag. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-09-28 Thread Michael Kruse via lldb-commits
Meinersbur requested changes to this revision. Meinersbur added a comment. The description of `LLVM_LINK_LLVM_DYLIB` reads: > Link tools against the libllvm dynamic library that is, its intend is what this patch would disable (for dynamic modules). I assume that you would like lldb-server to

Re: [Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-09-24 Thread Tobias Grosser via lldb-commits
grosser added a reviewer: Meinersbur. grosser added a comment. Pablo, thank you for taking Polly into account as well. I add Michael, who probably knows our cmake build system best. Repository: rL LLVM https://reviews.llvm.org/D24863 ___

Re: [Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-09-23 Thread Chris Bieneman via lldb-commits
beanz requested changes to this revision. beanz added a comment. This revision now requires changes to proceed. Making static archives only have dependencies on other static archives has serious implications and fundamentally breaks `LLVM_LINK_LLVM_DYLIB`. For example: libClangDriver.a depends

Re: [Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-09-23 Thread Brad King via lldb-commits
brad.king added a comment. > ensuring that when static .a libraries are build they only introduce cmake > transitive dependencies to other .a components. This sounds good from a design level. As for the implementation, I'm not particularly familiar with `llvm_add_library` and all its options

Re: [Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

2016-09-23 Thread Pavel Labath via lldb-commits
labath resigned from this revision. labath edited reviewers, added: beanz; removed: labath. labath added a comment. @beanz, could you look at the llvm side of this? Repository: rL LLVM https://reviews.llvm.org/D24863 ___ lldb-commits mailing