Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: source/Interpreter/Args.cpp:286-288 @@ -338,5 +285,5 @@ -const char **Args::GetConstArgumentVector() const { - if (!m_argv.empty()) -return const_cast(&m_argv[0]); - return nullptr; + // This is kind of gross, but it ensures that

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: source/Interpreter/Args.cpp:286-288 @@ -338,5 +285,5 @@ -const char **Args::GetConstArgumentVector() const { - if (!m_argv.empty()) -return const_cast(&m_argv[0]); - return nullptr; + // This is kind of gross, but it ensures that

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Greg Clayton via lldb-commits
clayborg added a comment. Ok, so just add the boolean arg to Args::GetArgumentVector and we are good to go. Comment at: source/Interpreter/Args.cpp:270-272 @@ -321,5 +269,5 @@ const char *Args::GetArgumentAtIndex(size_t idx) const { - if (idx < m_argv.size()) -return m_ar

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: source/Interpreter/Args.cpp:269-272 @@ -320,6 +268,6 @@ const char *Args::GetArgumentAtIndex(size_t idx) const { - if (idx < m_argv.size()) -return m_argv[idx]; + if (idx < m_args.size()) +return m_args[idx].c_str(); retur

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Interpreter/Args.cpp:264-265 @@ -315,3 +263,4 @@ size_t Args::GetArgumentCount() const { - if (m_argv.empty()) + if (

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 72657. zturner added a comment. Updated https://reviews.llvm.org/D24952 Files: examples/plugins/commands/fooplugin.cpp include/lldb/API/SBCommandInterpreter.h include/lldb/Host/OptionParser.h include/lldb/Interpreter/Args.h source/API/SBCommandInt

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Adrian McCarthy via lldb-commits
amccarth added a subscriber: amccarth. Comment at: include/lldb/Interpreter/Args.h:154 @@ -167,3 +153,3 @@ //-- - const char **GetConstArgumentVector() const; + void GetArgumentVector(std::vector &args) const;

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-27 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. Comment at: include/lldb/Interpreter/Args.h:150 @@ -147,19 +149,3 @@ /// /// @return /// An array of NULL terminate C string argument pointers that I think doxygen will complain about `@return` in a function returnin

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-26 Thread Zachary Turner via lldb-commits
zturner added a comment. Ignore the changes to `FileSpec`, it seems the two CLs I was working on got mixed together. https://reviews.llvm.org/D24952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D24952: Remove Args::m_argv

2016-09-26 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. zturner added subscribers: lldb-commits, LLDB. The `Args` class was trying to maintain two parallel argument vectors. One that owned the memory and contained `std::strings`, and one that contained `const char *`'s that could be