This revision was automatically updated to reflect the committed changes.
zturner marked an inline comment as done.
Closed by commit rL283344: Make lldb -Werror clean on Windows. (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D25247?vs=73515&id=73666#toc
Repository:
amccarth accepted this revision.
amccarth added a comment.
lgtm
> UDPSocket.cpp:106
> +#if defined(_MSC_VER) && defined(UNICODE)
> +"getaddrinfo(%s, %s, &hints, &info) returned error %i (%S)",
> +#else
Yuck. Given that this is going to get reduced from UTF-16 to MBCS, it might be
cle
zturner marked an inline comment as done.
zturner added inline comments.
> Eugene.Zelenko wrote in Platform.h:16
> This is application header. Should be in quotes. Same below.
Thanks for pointing this out. Fixed locally
https://reviews.llvm.org/D25247
___
Eugene.Zelenko added inline comments.
> Platform.h:16
> #include
> #include
> +#include
This is application header. Should be in quotes. Same below.
https://reviews.llvm.org/D25247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
zturner added a comment.
Thankfully, yes. Technically it's not supported by MSVC 2013, which is still a
supported LLVM compiler. But we said long ago that we require MSVC 2015 for
running the test suite on Windows. And in any case, LLVM is bumping to MSVC
2015 within the next 2 weeks. So I'
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Seems reasonable. For testing we'll yell at you if the buildbots break.
I take it we can now freely use the %z printf modifier.
https://reviews.llvm.org/D25247
zturner created this revision.
zturner added reviewers: amccarth, labath.
zturner added a subscriber: lldb-commits.
Herald added a subscriber: ki.stfu.
Some of this is in Windows specific code, but some of it is not. In a few
places I think I fixed real bugs in LLDB, but not sure how to really t
